fix(gateway): workspace ops broke on the documented Value::Null extra#190
Merged
Conversation
The typed WorkspaceReqExtra conversion (#186) rejected `Value::Null` — the value most read/git workspace callers pass per workspace_call's own docs ("Pass Value::Null (or an empty object) when the op needs none") — turning every ls/read/git browse into `bad workspace op field: invalid type: null`. Null now maps to defaults via parse_workspace_extra; deny_unknown_fields still rejects typo'd keys. Regression test covers null/{}/valid/typo. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix for a #186 regression that shipped in #187: the typed
WorkspaceReqExtraparse rejectedValue::Null, which is the documented "no op-specific fields" value most read/git workspace callers pass — every workspace ls/read/git browse returnedbad workspace op field: invalid type: null, expected struct WorkspaceReqExtra.Null now maps to defaults;
deny_unknown_fieldsstill catches typo'd keys. Regression test added (null / {} / valid / typo).🤖 Generated with Claude Code