Fix double block placement sound in clients 1.9+ #132
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calcastor
approved these changes
Jan 26, 2024
Contributor
calcastor
left a comment
calcastor
left a comment
There was a problem hiding this comment.
We've had this deployed to OCC for a couple months now and this does fix the described issue.
Collaborator
|
Merged as part of #147 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses a bug where block placement sounds were being played in the incorrect position, resulting in players using client version 1.9+ hearing the block placement sounds twice. The fix ensures that the block placement sounds are played at the correct place.
Fixes #89