Nodeguard upgrade, swaps in progress revamp, #85
Merged
Conversation
- Upgrade Go version from 1.20 to 1.24 - Pin LND to v0.19.0-beta with replace directive - Update Loop from v0.27.1-beta to v0.31.2-beta with pinning - Upgrade OpenTelemetry packages to v1.38.0 - Update gRPC to v1.64.1 - Add new dependencies for Docker testing and database migrations - Update various indirect dependencies for compatibility
- Bump Go version from 1.24 to 1.25 in go.mod - Regenerate lightning_rpc_mock.go with updated mockgen command - Add GetDebugInfo method to MockLightningClient interface - Remove deprecated streaming client mocks and swap client mocks
Add new command line flag for configuring swap lock timeout duration with default value of 30 minutes. This allows users to customize when swap locks automatically expire.
Add thread-safe locking system to prevent concurrent submarine and reverse swaps with configurable timeout periods and automatic lock expiration.
…estination details
Remove releaseSubmarineSwapLock() and releaseReverseSwapLock() methods along with their usage in tests. Locks now only expire via timeout mechanism to prevent spam attacks. Updated test comments to clarify production behavior where manual release is not available.
RodriFS
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nodeguard upgraded withdrawals for swaps in to trigger, I've also added a rate-limited instead of 1 at-at-time swap lock cause this led to issues in the past as loop stuck on those swaps, now it's time-based lock which will unlock
I've also removed per channel swap, let's try if this approach like autoloop that makes liquidator great again.