Swap provider to support per-channel locking#86
Merged
Conversation
Contributor
Jossec101
commented
Sep 18, 2025
Jossec101
commented
- Add ChannelId field to submarine swap requests
- Replace global swap locks with per-channel lock maps
- Update lock acquisition/release methods to accept channel ID
- Fix pointer dereference for swap status in fee recording
- Simplify reverse swap request to use single ChannelId instead of ChannelSet
- Add ChannelId field to submarine swap requests - Replace global swap locks with per-channel lock maps - Update lock acquisition/release methods to accept channel ID - Fix pointer dereference for swap status in fee recording - Simplify reverse swap request to use single ChannelId instead of ChannelSet
…annel Implement cross-type swap locking to prevent simultaneous submarine and reverse swaps on the same channel. Add validation logic to check for existing locks of opposite swap types before acquiring new locks
RodriFS
previously approved these changes
Sep 18, 2025
- Change MonitorSwap mock returns from value to pointer types - Remove unused MockNodeGuardServiceServer from generated mock file - Update mock generation command to use interface-based approach
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.