Skip to content

fix: import load_from_optimizer lazily to break a spawn-time cycle #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luciaquirke merged 1 commit into from
Jul 29, 2026
Merged

fix: import load_from_optimizer lazily to break a spawn-time cycle #368

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion bergson/magic/trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@

from ..config.config import TrainingConfig
from ..data import sorted_checkpoints
from ..utils.load_from_optimizer import save_second_moments_as_optimizer_pt
from ..utils.utils import get_device
from ..utils.worker_utils import setup_model_and_peft
from .config import MagicSaveMode
Expand Down Expand Up @@ -623,6 +622,12 @@ def train(

# Write before the DCP save starts, into the same directory.
if optimizer_cfg is not None:
# Local import: at module scope this cycles back into
# magic.trainer via the package __init__.
from ..utils.load_from_optimizer import (
save_second_moments_as_optimizer_pt,
)

os.makedirs(p, exist_ok=True)
save_second_moments_as_optimizer_pt(
self.model,
Expand Down
Loading