Repository navigation
zig: zig fmt on five dsv41-zig base files (Zig format check fails on every PR) - #43
Merged
Merged
Conversation
…very pull request) zig fmt 0.17.0 changes only layout and @intFromEnum to @backingInt. The Zig format check fails on these five base-branch files in every open dsv41-zig pull request, also where the pull request does not touch them.
Elevatormusic
added
the
type: fix
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Elevatormusic
added a commit
that referenced
this pull request
Oct 24, 2026
Elevatormusic
added a commit
that referenced
this pull request
Oct 24, 2026
Elevatormusic
added a commit
that referenced
this pull request
Oct 24, 2026
Elevatormusic
added a commit
that referenced
this pull request
Oct 24, 2026
Elevatormusic
added a commit
that referenced
this pull request
Oct 24, 2026
Elevatormusic
added a commit
that referenced
this pull request
Oct 24, 2026
Elevatormusic
added a commit
that referenced
this pull request
Oct 24, 2026
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
zig fmt --check build.zig zigfails on five files of thedsv41-zigbase branch. Thus the Zig format check fails on every opendsv41-zigpull request, also where the pull request does not touch these files. This change runszig fmt(0.17.0) on the five files:dsv41/exl3_linear.zig,dsv41/round.zig,dsv41/split_bench_main.zig,dsv41/tri_basic.zigandserver/effort_values_test.zig.The diff is layout, plus
@intFromEnumto@backingInt(the formatter's own rewrite; the rest ofzig/already uses@backingInt, with 0@intFromEnumleft). Refs #29, #30, #31, #32, #33, #38, #39, #40, #41.Receipt
dsv41-zig@84ded67dplus this commit. Zig 0.17.0 (x86_64-windows), CPU only.zig fmt --check build.zig zig: rc 1 before, rc 0 after. The CIzig build testjobs run on this pull request.Checklist
"draft": false(no change to the math).This change was written with help from an AI coding assistant.