fix: TTL hold release, session sweeper, and post-purchase Done - #7
Merged
Merged
Conversation
Expire lapsed sessions with releaseHold on touch and via an in-process sweeper, label the header Done only after a completed order, and update README/CONTEXT/ADR honesty notes. Also folds shared checkout action and policy refactors from the quality pass. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session_lapsed) now releases the inventory hold on request-time expiry and via an in-processSessionExpirySweeper(~30s), so abandoned checkouts do not strand listings.Test plan
pnpm --filter api exec jest— checkout-service + sweeper tests greenpnpm --filter web exec jest --testPathPattern='site-header|checkout-client|page.ssr'Made with Cursor