fix(changesets): version the workspace's private packages again - #3
Merged
Merged
Conversation
Every package here is `private: true`, and the changesets 2 -> 3 upgrade in the
modernize PR changed the default so private packages are skipped entirely. The
symptom is silent: `changeset status` prints an empty "Packages to be bumped:",
`changeset version` reports "All files have been updated" and writes nothing, and
the Release workflow then fails opening a PR with "No commits between main and
changeset-release/main" — three messages, none of which mention private packages.
`privatePackages: { version: true, tag: false }` restores the changesets 2
behaviour: versions and CHANGELOGs are written, nothing is tagged or published,
which is what this repo wants — it is an app template, not a published library.
Verified: status now lists all four @repo packages plus api, and version consumes
the three pending changesets and writes the CHANGELOGs.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Release workflow on
mainis red. Three separate causes, and this is the last one — the other two are already fixed.The bug
Every package in this workspace is
private: true. The changesets 2 → 3 upgrade in the modernize PR changed the default so private packages are skipped entirely, which means nothing has been versioned since.It fails silently at every step:
…and then the workflow fails on something that sounds unrelated:
Three messages, none mentioning private packages.
privatePackages: { version: true, tag: false }restores the changesets 2 behaviour: versions and CHANGELOGs get written, nothing is tagged or published — right for an app template rather than a published library.Verified
changeset versionconsumes the three pending changesets and writes the CHANGELOGs. I reverted that locally — producing the bump is the workflow's job, so the changesets are still pending here.The other two, for the record
release.ymlhad no GitHub Packages credential (fixed in ci: authenticate the release workflow to GitHub Packages #2). It only runs on push tomain, so no PR could ever catch it.Once this merges, Release should open a "chore: version packages" PR on its own.
🤖 Generated with Claude Code