Update to Elixir 1.9.4-otp22#53
Open
michaelkschmidt wants to merge 1 commit into
Open
Conversation
|
1.9.4 is already on Chocolatey? Am I missing something?
…On Fri, Nov 8, 2019, 8:26 PM Michael Schmidt ***@***.***> wrote:
This updates to using the Elixir version compiled for OTP-22
------------------------------
You can view, comment on, or merge this pull request online at:
#53
Commit Summary
- Update to Elixir 1.9.4-otp22
File Changes
- *M* Elixir/Elixir.nuspec
<https://github.com/ElixirWin/ChocolateyPackages/pull/53/files#diff-0>
(4)
- *M* Elixir/tools/chocolateyInstall.ps1
<https://github.com/ElixirWin/ChocolateyPackages/pull/53/files#diff-1>
(6)
- *M* Elixir/tools/chocolateyUninstall.ps1
<https://github.com/ElixirWin/ChocolateyPackages/pull/53/files#diff-2>
(10)
Patch Links:
- https://github.com/ElixirWin/ChocolateyPackages/pull/53.patch
- https://github.com/ElixirWin/ChocolateyPackages/pull/53.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#53?email_source=notifications&email_token=AABFOFOPLMFSBPIT3R4JEATQSYGS3A5CNFSM4JLBS6LKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HYDJNXQ>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABFOFI4WSRYYAXYBJ3FDU3QSYGS3ANCNFSM4JLBS6LA>
.
|
Author
|
Its not using the version that is compiled for OTP-22 |
|
I only see one "precompiled.zip" out there for 1.9.4. Where is the version
compiled against OTP 22? I just want to know for future reference
…On Fri, Nov 8, 2019, 8:43 PM Michael Schmidt ***@***.***> wrote:
Its not using the version that is compiled for OTP-22
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#53?email_source=notifications&email_token=AABFOFPZHLCEZEQGRVGSQJLQSYIVPA5CNFSM4JLBS6LKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDT2SZQ#issuecomment-552053094>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABFOFMIE6DRJK6ET75MODLQSYIVPANCNFSM4JLBS6LA>
.
|
Author
|
Its If you think we need to support OTP < 22 going forward I can work on figuring out what OTP is installed, but I feel like most Elixir people will update both when they update |
|
So 1.9.4-otp-22 is up there but it's still defaulted to 1.9.4. What do you
think--want to default it to 1.9.4-otp22? Or say something on the Elixir
Forum so people are aware it's there?
…On Fri, Nov 8, 2019 at 9:26 PM Michael Schmidt ***@***.***> wrote:
Its https://repo.hex.pm/builds/elixir/v1.9.4-otp-22.zip
If you think we need to support OTP < 22 going forward I can work on
figuring out what OTP is installed, but I feel like most Elixir people will
update both when they update
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#53?email_source=notifications&email_token=AABFOFJ3AKPSBWFMVSFKGZLQSYNVTA5CNFSM4JLBS6LKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDT3QVA#issuecomment-552056916>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABFOFIHPW6SEC7B7IO6OELQSYNVTANCNFSM4JLBS6LA>
.
--
Onorio Catenacci
http://onor.io
https://twitter.com/OldDutchCap
|
Author
|
I think I goofed up the version--the "-otp-22" string is flagging it as a pre-release of some kind. Is it ok if I push it as "1.9.4.1" ? |
|
I'd rather you didn't.
Let me do a little research; maybe there have been other variant build
packages on Chocolatey in the past.
I want people to be aware of the OTP 22 option but I am willing to bet
there are places using Elixir who would like 1.9.4 to test but may have to
stay on older versions of Erlang. Hence I want both versions readily
available.
…On Mon, Nov 11, 2019 at 11:07 AM Michael Schmidt ***@***.***> wrote:
I think I goofed up the version--the "-otp-22" string is flagging it as a
pre-release of some kind. Is it ok if I push it as "1.9.4.1" ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#53?email_source=notifications&email_token=AABFOFLFLXHGYCXDWMU2TYLQTF7LNA5CNFSM4JLBS6LKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDXJF6Q#issuecomment-552506106>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABFOFJ7SHMAUY4TICBWEM3QTF7LNANCNFSM4JLBS6LA>
.
--
Onorio Catenacci
http://onor.io
https://twitter.com/OldDutchCap
|
|
From what I've seen when there are variant builds (beyond x86/x64) the
general approach seems to be different packages. But I think there may be
another better option. Maybe a couple of better options.
1.) I agree that most folks are likely to want the OTP 22 build if they are
using 1.9.4. So maybe we repush the 1.9.4-OTP22 as simply 1.9.4 and we
repush 1.9.4 as 1.9.4-preOTP22 or something like that.
2.) Unify the two packages and add a check for the presence of OTP22. This
isn't much different from detecting x86 vs. x64 and it shouldn't be that
difficult. If no Erlang is present then Chocolatey automatically grabs the
latest version of Erlang; if a version is present we can check the version
and if it's prior to 22, we install the 1.9.4-preOTP22. Otherwise we
install 1.9.4-OTP22.
How does that idea sound?
On Mon, Nov 11, 2019 at 11:12 AM Onorio Catenacci <Catenacci@ieee.org>
wrote:
… I'd rather you didn't.
Let me do a little research; maybe there have been other variant build
packages on Chocolatey in the past.
I want people to be aware of the OTP 22 option but I am willing to bet
there are places using Elixir who would like 1.9.4 to test but may have to
stay on older versions of Erlang. Hence I want both versions readily
available.
On Mon, Nov 11, 2019 at 11:07 AM Michael Schmidt ***@***.***>
wrote:
> I think I goofed up the version--the "-otp-22" string is flagging it as a
> pre-release of some kind. Is it ok if I push it as "1.9.4.1" ?
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#53?email_source=notifications&email_token=AABFOFLFLXHGYCXDWMU2TYLQTF7LNA5CNFSM4JLBS6LKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDXJF6Q#issuecomment-552506106>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AABFOFJ7SHMAUY4TICBWEM3QTF7LNANCNFSM4JLBS6LA>
> .
>
--
Onorio Catenacci
http://onor.io
https://twitter.com/OldDutchCap
--
Onorio Catenacci
http://onor.io
https://twitter.com/OldDutchCap
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates to using the Elixir version compiled for OTP-22