Skip to content

Give the portal back the dropdown the CFP asked Audience level with - #322

Merged
EllAchE merged 3 commits into
mainfrom
portal-level-select-20260817t1815
Aug 18, 2026
Merged

Give the portal back the dropdown the CFP asked Audience level with#322
EllAchE merged 3 commits into
mainfrom
portal-level-select-20260817t1815

Conversation

@EllAchE

@EllAchE EllAchE commented Aug 17, 2026

Copy link
Copy Markdown
Owner

The post-submission edit view degrades and narrows the form. "Audience level" drops from a
Beginner/Intermediate/Advanced dropdown to a free-text input, so a speaker can save an arbitrary
string into a constrained field; and Session format, Track and Tags are not editable at all
(Track is read-only header text), leaving no self-service correction route for the fields
organizers filter and route on.

Flagged major by the call-for-papers judge. This PR is the first half — Audience level. Format,
Track and Tags are a follow-up, for the reason below.

What was wrong

submissionFields filters every built-in key out of what the portal editor renders, so the editor
hardcodes the built-ins it wants. level was hardcoded as an <Input> — an open text box for a
question the public form asks with a dropdown. submissionEditSchema then accepted any string up
to 60 characters into submission.level, which is what the review queue filters on and what the
exports group by. A speaker who typed anything at all put a value there that nothing else in the
product will ever match.

The fix

submissionLevelOptions(formId) reads what the form itself offers, falling back to the shared
DEFAULT_LEVELS when the field is present with no custom list. The editor renders a <Select> from
that, so an organizer who replaced the options gets their options, and a form whose organizer removed
the field renders nothing rather than an empty box.

The same rule server-side, in the exported pure levelError(value, options, current). The edit view
posts to a server action, and a server action takes whatever it is given; a <select> limits the
browser, not the request.

Two values pass that are not on the list, both because the old box let anything through:

  • A blank. The question is optional, so clearing it is an answer.
  • Whatever the record already says. A speaker fixing a typo in their title should not be blocked
    by a value they did not touch and cannot re-enter. The select offers that stored value too, so the
    page shows what the submission actually says instead of silently presenting the first option and
    saving it on the next edit. Moving off such a value is one-way, and levelError will not let it
    be applied to a different submission.

What this does not fix

Session format, Track and Tags remain uneditable. The judge filed both halves as one defect, but
they are different work: this one is data integrity on a column that already exists on the
submission row, while those three are missing capability — they need PortalSubmission extended
with formatId/trackId/tagIds, updateMySubmission extended to write them and to replace the
submission_tag rows, and the editor rendering their taxonomy options. One concern per PR, so that
is a follow-up rather than a bigger diff here.

Verification

bun run lint, bun run typecheck, bun run test (190 files, 2041 tests) and bun run build all
pass. bun run docs:openapi and bun run docs:mcp regenerate to no diff.

Eight new tests on levelError, covering both exceptions above, an organizer's own option list, and
a form that does not ask the question. The <Select> itself is not covered: this repo has no DOM
test tooling, so a rendered select's option list is not something a test here can inspect.

Part of the 2026-08-17T05-46-05 evaluation cycle. Not merged, not deployed.

A speaker picks Beginner, Intermediate or Advanced on the public form. Opening
the same submission in the portal to edit it presented Audience level as an
empty text box: any string at all could be saved into the column the review
queue filters on and the exports group by, and nothing in the product would ever
match it again.

The edit view now renders the options the form itself offers, read from the form
rather than hardcoded, so an organizer who replaced the list gets their list. A
form whose organizer removed the field offers nothing rather than an empty box.

Server-side too. The edit view posts to a server action, and a server action
takes whatever it is given, so the value is checked against the same list there.
Two exceptions, both because the old box let anything through: a blank clears
the field, which is what an optional question means, and whatever the record
already says passes unchanged -- a speaker fixing a typo in their title should
not be blocked by a value they did not touch and could not re-enter. Moving off
such a value is one-way; the select offers it so it is visible, and choosing
anything else is final.
The select only renders when the form has the field, so an empty `level` on a
form without it means nobody was shown the question -- not that a speaker
cleared it. Writing it through dropped an existing value on the next save of
anything else on the page.
* Let a speaker fix the format, track and tags they picked

All three were asked on the public form and none survived into the portal's edit
view. Track showed up as read-only header text; format and tags did not show up
at all. A speaker who chose the wrong track had no way to say so, on exactly the
fields organizers filter, route and schedule on -- so the correction went by
email, if it happened.

The edit view now offers the event's own lists: two selects and a checkbox list,
the same three questions the form asked. Values are ids rather than names, so
renaming a track does not detach the submissions that chose it, and the server
action checks each one against the same list rather than trusting the post.

A form that does not ask one of these renders no control for it, and a save from
that form now leaves the column alone rather than clearing it. Tags are replaced
as a set, the way a submit replaces them; an empty set means untagged, and no
`tagIds` at all means the caller was not editing tags.

* Show only the questions a submission was actually asked (#326)

A question conditioned on "Session format is Workshop" was rendered on a
Talk everywhere a submission is read back: the speaker's portal editor and
the reviewer's Questionnaire panel. The reviewer's copy is the damaging one,
because "Workshop prerequisites —" reads as a question the speaker skipped.

The visibility engine was right; what it was handed was not. `isFieldVisible`
treats a condition whose parent is missing from the map as no condition —
correct for a rule orphaned by a deleted question, wrong for a parent the
caller filtered out first. `submissionFields` dropped the built-ins before
resolving, so every rule pointing at the built-in format, track or level was
unresolvable and its field showed unconditionally.

`askedQuestions` resolves over the whole form, built-in columns rehydrated
back into answer positions, and leaves dropping the built-ins to the caller.

Three surfaces move onto it:

- The portal editor renders only the questions this submission was asked.
  A file question is resolved but still not rendered, because it is a value
  another question can be conditioned on and the portal has nowhere to
  re-upload from.
- `saveSubmissionAction` reads back only those questions. Reading every
  question the form holds stored an empty answer to one never shown, which
  afterwards is indistinguishable from a speaker who was asked and skipped.
  `updateMySubmission` resolves against the values being written, so a
  speaker switching a Talk to a Workshop is asked the workshop questions by
  that same save.
- The reviewer's Questionnaire filters at render, so rows already carrying
  an empty answer from the old write path read correctly without a backfill.
  An answer whose question is gone from the form is kept — there is no rule
  left to consult, and the panel already falls back to the raw key.

Switching format reveals the newly asked questions on the next load: the
format control sits outside `FieldSet`, so the browser cannot recompute
visibility live.

Found by `sbek` CFP-S2 against run 2026-08-17T05-46-05.
@EllAchE
EllAchE merged commit c11af6b into main Aug 18, 2026
7 checks passed
@EllAchE
EllAchE deleted the portal-level-select-20260817t1815 branch August 18, 2026 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant