Show the organizer every link a speaker has, not one called Website - #327
Merged
Conversation
The organizer speaker record had a single "Website" input. The portal has a Links section. Both write `participant.links`, and `websiteOf` resolved that input by looking for the link labelled exactly "Website". So when a speaker relabelled the row an organizer had typed her LinkedIn URL into and added a second link, the organizer's Website field went empty and her two links had nowhere to appear. Nothing was destroyed; the organizer's view of the field was one link wide and the speaker had moved off it. From behind that input the two are indistinguishable, which is the defect. The organizer form gets the same Links editor the portal has — label, address, remove, add — capped at the eight `profileSchema` already enforces, so the limit is refused by the button rather than by the save. `profileLinks` names who may say a link is gone. A caller that sent the whole set is replacing it, and is the only caller entitled to: it is the one that showed the organizer every link before asking. A caller that sent only `website` — the CSV import, the API — is naming one link out of the set and leaving the rest alone. That also closes a smaller hole. With only `website` to work with, blanking the input could never remove a link, because `mergeLinks` reads an empty value as no opinion — right for a CSV column, wrong for a field an organizer has just cleared. The set-sending path can clear it. `speaker.website` is unchanged and still exported; the CSV import and export both name that column. Found by `sbek` SPK-S1 against run 2026-08-17T05-46-05.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sbekSPK-S1, run2026-08-17T05-46-05:What was actually happening
Both sides write the same column —
participant.links, a labelled set. The portal edits the set. The organizer screen had one text input, andwebsiteOfresolved it by looking for the link whose label is exactlyWebsite.So when the speaker relabelled the row the organizer had typed her LinkedIn URL into, and added a second, the organizer's Website field went empty and her two links had nowhere to appear. Nothing was destroyed; the organizer's view of the field was one link wide, and the speaker had moved off it. From behind that single input the two are indistinguishable, which is the defect.
The fix
The organizer speaker form gets the same Links editor the portal has: label, address, remove, add — capped at the eight
profileSchemaalready enforces, so the limit is refused by the button rather than by the save.profileLinksnames who may say a link is gone. A caller that sent the whole set is replacing it, and is the only caller entitled to, because it is the one that showed the organizer every link before asking. A caller that sent onlywebsite— the CSV import, the API — is naming one link and leaving the rest alone.This also closes a smaller hole: with only
websiteto work with, blanking that input could never remove a link (mergeLinksreads an empty value as no opinion, which is right for a CSV column and wrong for a field an organizer has just cleared). The set-sending path can now clear it.speaker.websiteis unchanged and still exported — the CSV import and export both name that column.Tests
lib/services/speaker-profile-links.test.ts, 8 cases: no links sent keeps what is stored; a sent set replaces it; an empty sent set clears; a bare website leaves the rest alone and replaces rather than duplicates the stored one; a website folds into a sent set; a blank website is no opinion; the set caps at eight.lint,typecheck,test(2041 in 190 files),build,docs:openapi,docs:mcpall clean.Not merged and not deployed.