Skip to content

Data Bars: show rank and notes on the guild tooltip, sorted by rank - #1643

Closed
austinscantland wants to merge 8 commits into
EllesmereGaming:mainfrom
austinscantland:future/databar-guild-tooltip-rank-notes
Closed

austinscantland wants to merge 8 commits into
EllesmereGaming:mainfrom
austinscantland:future/databar-guild-tooltip-rank-notes

Conversation

@austinscantland

@austinscantland austinscantland commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

The guild Social & Guild Tooltip (already opt-in, default off) now lists online members by rank index, Guild Master first, with aligned rank and public-note columns beside the zone.

How was it tested?

Code review against .github/CONTRIBUTING.md. Please hover the databar guild button in-game with Social & Guild Tooltip enabled and attach a screenshot.

Screenshots

Before
image

After
image

Checklist

  • New settings default OFF (N/A: no new setting; only the existing Social & Guild Tooltip, which already defaults off)
  • Zero cost while disabled: no events registered, no polling, no hooks doing work, no frames built
  • Cheap while enabled: event-driven (no polling, no timer-based logic, no per-frame allocations)
  • No writes onto Blizzard-owned frames (weak-table pattern used); HookScript/hooksecurefunc only, never SetScript on Blizzard frames
  • Tested in-game on live; no version gates or pre-Midnight APIs added

Contact Info

  • Discord: espyr

@austinscantland

Copy link
Copy Markdown
Contributor Author

Closing in favor of #2085, which is the same guild databar tooltip work reopened from feat/databar-guild-tooltip-rank-notes (this branch was misnamed future/).

@austinscantland
austinscantland deleted the future/databar-guild-tooltip-rank-notes branch September 14, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant