Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes retained Custom Active State timers overriding normally tracked CDM spells. For example, after adding Imp Lord as a Custom Spell ID, configuring a 120-second active state, removing it, and adding it through normal CDM tracking, the old timer could still cover the native cooldown display.
Apply the existing
IsInjectedFramecheck to user active-overlay rules, matching the restriction already used for custom cooldown-state effects. Native CDM icons now keep their normal display, including when moved to a custom bar. Genuine injected spell, racial, preset, item, and trinket icons retain their custom timers. Saved settings are preserved for reuse; built-in active rules keep their existing scope.How was it tested?
main(271ffc30, v9.1.8): one Lua file changed; no API, TOC, settings-schema, or public signature changes.Screenshots
Before/after screenshots were not supplied. The visual result was reported through in-game testing.
Checklist
HookScript/hooksecurefunconly, neverSetScripton Blizzard frames - verified for the diff: only reads existing frame-kind flags; no new frame writes or hooks.