Add opt-in chat reports to damage meter windows - #2092
Draft
NYTEMODEONLY wants to merge 2 commits into
Draft
NYTEMODEONLY wants to merge 2 commits into
NYTEMODEONLY wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds opt-in chat reports to damage meter windows. Enable Damage Meters > Header > Enable Chat Reports to add the existing speaker asset to each header. The dialog previews that window's metric and segment, defaults to five entries, and sends the header followed by every selected available entry in ranked order from one click.
This is an independent addition based on
main; it does not depend on #2090, Details, or changes to the chat module. The new setting defaults off. This PR stays draft while feature submissions are paused under the contribution guide and until the live checks and screenshots below are complete.Sending behavior
Outdoor Say/custom-channel messages stay on the original button-click stack. Other destinations use a cancellable 0.3-second interval solely to pace the explicitly requested chat messages. There is no background reporting, collection, polling, or timer gate for combat-data access. Blizzard channel permissions, flood limits and server delivery still apply; a successful API call does not acknowledge server delivery.
How was it tested?
python .tools/damage-meter-report-tests/run_reports.pywith Python andlupa's Lua 5.1 runtime: passes. Compiles all damage-meter Lua files and the options file, including Lua 5.1 local/upvalue limits.git diff --checkand ASCII checks on every added line: pass. Tests and their README live under.tools, already excluded from release packages.The installed precursor was exercised by the contributor, but this upstream cleanup has not yet been validated in the live client. Native widget rendering, actual chat delivery, combat taint and the default-off/profile lifecycle need a Midnight 12.1+ pass. The mocks do not certify those results. The repeatable live checklist is in
.tools/damage-meter-report-tests/README.md.Screenshots
Contributor-provided in-game capture of the installed version, showing the themed report dialog and the damage/healing meter headers. The selected five-entry limit previews the one available player plus the report header.
This captures the installed version; the upstream cleanup's remaining live checks are still pending. A matched before capture and the resulting chat messages are not shown here.
Checklist