Skip to content

Fix crafted item colours and sorting by crest tier - #2093

Open
andybergon wants to merge 1 commit into
EllesmereGaming:mainfrom
andybergon:t3code/fix-crafted-item-colours
Open

andybergon wants to merge 1 commit into
EllesmereGaming:mainfrom
andybergon:t3code/fix-crafted-item-colours

Conversation

@andybergon

Copy link
Copy Markdown
Contributor

What does this PR do?

Match current Hero/Myth crafted gear to its crest-tier colour and sorting priority in bags. A 331 Myth craft currently shows epic purple and sorts below Champion gear because it has no upgrade track. It now shows Myth orange and sorts with Myth gear, using its effective item level.

Bank item-level text uses the same craft colours. Crafts do not gain upgrade-rank numbers. Existing tracked gear, older crafts, rarity fallbacks, and custom colour overrides retain their behaviour. No new settings.

How was it tested?

  • In-game screenshots confirm the 331 craft colour correction.
  • Lua 5.1 syntax checks for all three changed files; focused assertions for Hero/Myth colours, old/unknown fallbacks, bonus-list boundaries, craft sort rank, effective item level, and absent upgrade-rank text.
  • Independent Claude review checked the final split and confirmed the craft sort correction. Hero crafts, bank colours, and the final sort correction still need live verification.

Screenshots

Craft colour before and after

Before: the 331 crafts use epic purple.

Before

After: the 331 crafts use Myth orange. This screenshot verifies colour; it predates the final craft sort correction.

After

Checklist

  • New settings default OFF: N/A, focused bug fix with no new settings.
  • Zero cost while disabled: no new events, polling, hooks, or frames.
  • Cheap while enabled: refresh-time colour lookup; crafted sort metadata uses the existing bounded cache.
  • No new writes or scripts on Blizzard-owned frames.
  • Tested in-game on live; no version gates or pre-Midnight APIs added. Colour is screenshot-verified; remaining coverage is disclosed above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant