Fix crafted item colours and sorting by crest tier - #2093
Open
andybergon wants to merge 1 commit into
Open
andybergon wants to merge 1 commit into
andybergon wants to merge 1 commit into
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Match current Hero/Myth crafted gear to its crest-tier colour and sorting priority in bags. A 331 Myth craft currently shows epic purple and sorts below Champion gear because it has no upgrade track. It now shows Myth orange and sorts with Myth gear, using its effective item level.
Bank item-level text uses the same craft colours. Crafts do not gain upgrade-rank numbers. Existing tracked gear, older crafts, rarity fallbacks, and custom colour overrides retain their behaviour. No new settings.
How was it tested?
Screenshots
Craft colour before and after
Before: the 331 crafts use epic purple.
After: the 331 crafts use Myth orange. This screenshot verifies colour; it predates the final craft sort correction.
Checklist