fix(auras): refine offensive cooldown defaults - #2097
Open
andybergon wants to merge 1 commit into
Open
andybergon wants to merge 1 commit into
andybergon wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update Offensive CDs to show major active damage windows for any healer.
Add Splinterstorm, Finish the Job, Dominion of Argus, Rain of Chaos, and Crashing Chaos enabled by default. Add Celestial Conduit readiness (1248992) unchecked: it allows Conduit to be cast for up to one minute, rather than representing the active channel.
Remove Icy Veins (12472) and Storm, Earth, and Fire (137639), which Blizzard removed in the Midnight pre-expansion update.
Keep Shadow Dance, Guardian Berserk, Breath of Eons, and Tyrant's Oblation available but unchecked by default. Shadow Dance is optional to reduce frequent short-window indicators. Existing alternate spell IDs continue to follow their parent checkbox. Potions remain exclusively in the unchanged Consumables preset.
This changes the shared preset consumed by Raid Frames and Player Aura Bars. Existing checkbox choices for retained entries remain intact; the new defaults apply when a preset entry is first seeded. Raid Frames prunes removed curated entries automatically, while preserving custom entries and direct indicator selections. Existing Player Aura Bars filters retain removed entries until manually deleted in the Filter Editor.
How was it tested?
git diff --checkpassed. Reviewed the existing preset merge logic.Checklist