Skip to content

fix(auras): refine offensive cooldown defaults - #2097

Open
andybergon wants to merge 1 commit into
EllesmereGaming:mainfrom
andybergon:t3code/compare-pihelper-tracked-buffs
Open

andybergon wants to merge 1 commit into
EllesmereGaming:mainfrom
andybergon:t3code/compare-pihelper-tracked-buffs

Conversation

@andybergon

Copy link
Copy Markdown
Contributor

What does this PR do?

Update Offensive CDs to show major active damage windows for any healer.

Add Splinterstorm, Finish the Job, Dominion of Argus, Rain of Chaos, and Crashing Chaos enabled by default. Add Celestial Conduit readiness (1248992) unchecked: it allows Conduit to be cast for up to one minute, rather than representing the active channel.

Remove Icy Veins (12472) and Storm, Earth, and Fire (137639), which Blizzard removed in the Midnight pre-expansion update.

Keep Shadow Dance, Guardian Berserk, Breath of Eons, and Tyrant's Oblation available but unchecked by default. Shadow Dance is optional to reduce frequent short-window indicators. Existing alternate spell IDs continue to follow their parent checkbox. Potions remain exclusively in the unchanged Consumables preset.

This changes the shared preset consumed by Raid Frames and Player Aura Bars. Existing checkbox choices for retained entries remain intact; the new defaults apply when a preset entry is first seeded. Raid Frames prunes removed curated entries automatically, while preserving custom entries and direct indicator selections. Existing Player Aura Bars filters retain removed entries until manually deleted in the Filter Editor.

How was it tested?

  • Verified 29 enabled rows and five unchecked entries, including Shadow Dance and Celestial Conduit readiness. Neither removed spell ID remains in the preset file.
  • Verified the Consumables preset is unchanged.
  • git diff --check passed. Reviewed the existing preset merge logic.
  • In-game aura detection has not been tested.

Checklist

  • New settings default OFF: N/A, no new settings. Preset defaults are revised as described above; saved selections are preserved.
  • Zero cost while disabled: no new events, polling, hooks, or frames.
  • Cheap while enabled: uses the existing aura filtering path.
  • No writes onto Blizzard-owned frames: data-only change.
  • Tested in-game on live: pending. No version gates or pre-Midnight APIs added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant