Conversation
Bug: Issue: Targeted Spell Bars and AuraBuffReminders sections set to only show in specific content types (e.g. Mythic/Non-Mythic Dungeons) still showed up in World Tier Lair boss fights. Both modules classify the current zone into a location bucket via a fixed allowlist of instanceType/difficultyID combos; anything unrecognized falls through to an "always show" fallback meant for genuinely unmappable content like arenas/PvP. Lairs are a brand-new instanced content type (four difficulty tiers: World, Normal, Heroic, Mythic) that didn't exist when these allowlists were written, so they fell into that same always-show fallback in both places, and neither options panel had a Lair entry to filter them with. Fix: added a single "lair" location bucket to both modules, covering all four Lair difficulty tiers at once, detected via hasWorldTier (Blizzard's own GetInstanceInfo() flag for World-Tier-scaled content, added in patch 12.0.7) rather than guessing at specific difficulty IDs, checked ahead of the existing instanceType/difficultyID branches. Added a matching "Lair" checkbox to both Where to Show options lists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: https://discord.com/channels/585577383847788554/1545057451743772732
Issue: Targeted Spell Bars and AuraBuffReminders sections set to only show in specific content types (e.g. Mythic/Non-Mythic Dungeons) still showed up in World Tier Lair boss fights. Both modules classify the current zone into a location bucket via a fixed allowlist of instanceType/difficultyID combos; anything unrecognized falls through to an "always show" fallback meant for genuinely unmappable content like arenas/PvP. Lairs are a brand-new instanced content type (four difficulty tiers: World, Normal, Heroic, Mythic) that didn't exist when these allowlists were written, so they fell into that same always-show fallback in both places, and neither options panel had a Lair entry to filter them with.
Fix: added a single "lair" location bucket to both modules, covering all four Lair difficulty tiers at once, detected via hasWorldTier (Blizzard's own GetInstanceInfo() flag for World-Tier-scaled content, added in patch 12.0.7) rather than guessing at specific difficulty IDs, checked ahead of the existing instanceType/difficultyID branches. Added a matching "Lair" checkbox to both Where to Show options lists.