Conversation
Bug: Issue: The shared "Instances" Show/Hide visibility axis (used by Quest Tracker and every other module offering "Hide for Instances") never matched battlegrounds. Reporter confirmed a random battleground stayed visible with "Hide for Instances" checked, while dungeons/raids/delves correctly hid. Fix: EllesmereUI.IsInInstancedContent() early-returned false whenever GetInstanceInfo()'s difficultyID was <= 0, before ever checking instanceType. Battlegrounds report a difficultyID of 0 (PvP content has no difficulty setting), so that guard tripped for every battleground regardless of the instanceType == "pvp" check further down. Removed the redundant difficultyID gate; the instanceType whitelist already correctly scopes the probe to real instanced content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: https://discord.com/channels/585577383847788554/1544897213438627870
Issue: The shared "Instances" Show/Hide visibility axis (used by Quest Tracker and every other module offering "Hide for Instances") never matched battlegrounds. Reporter confirmed a random battleground stayed visible with "Hide for Instances" checked, while dungeons/raids/delves correctly hid.
Fix: EllesmereUI.IsInInstancedContent() early-returned false whenever GetInstanceInfo()'s difficultyID was <= 0, before ever checking instanceType. Battlegrounds report a difficultyID of 0 (PvP content has no difficulty setting), so that guard tripped for every battleground regardless of the instanceType == "pvp" check further down. Removed the redundant difficultyID gate; the instanceType whitelist already correctly scopes the probe to real instanced content.