Conversation
Bug:
Issue: Quick Fire's Hot Keys section (Place/Undo/Clear world-marker
binds) would not register mouse button binds at all, including
modifier chords like Ctrl+Shift+Middle Mouse Button.
Fix: AddQuickFireKeybind's capture button only ever registered
LeftButtonUp/RightButtonUp and had no OnClick handling to treat a
click as the captured chord -- OnKeyDown, its only capture path, never
fires for mouse buttons at all. Mirrored the working pattern already
used by Quickdraw's own keybind picker: RegisterForClicks("AnyUp"),
plus an OnClick branch that, while listening, takes any button other
than Left/Right as the chord via GetConvertedKeyOrButton +
CreateKeyChordStringUsingMetaKeyState, modifiers included. A modified
Left/Right click (e.g. Ctrl+Left) is also captured as a chord; only a
PLAIN Left/Right click keeps its fixed meaning on this button
(arm/unbind), per its own tooltip. The runtime side
(SetOverrideBindingClick) already accepted mouse-button chord strings
without any changes -- only the options-panel capture widget was
missing the mouse path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: https://discord.com/channels/585577383847788554/1543997701966930073
Issue: Quick Fire's Hot Keys section (Place/Undo/Clear world-marker binds) would not register mouse button binds at all, including modifier chords like Ctrl+Shift+Middle Mouse Button.
Fix: AddQuickFireKeybind's capture button only ever registered LeftButtonUp/RightButtonUp and had no OnClick handling to treat a click as the captured chord -- OnKeyDown, its only capture path, never fires for mouse buttons at all. Mirrored the working pattern already used by Quickdraw's own keybind picker: RegisterForClicks("AnyUp"), plus an OnClick branch that, while listening, takes any button other than Left/Right as the chord via GetConvertedKeyOrButton + CreateKeyChordStringUsingMetaKeyState, modifiers included. A modified Left/Right click (e.g. Ctrl+Left) is also captured as a chord; only a PLAIN Left/Right click keeps its fixed meaning on this button (arm/unbind), per its own tooltip. The runtime side (SetOverrideBindingClick) already accepted mouse-button chord strings without any changes -- only the options-panel capture widget was missing the mouse path.