Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes Surarn's v9.1.8 report: selecting Show Non-Player Auras on one debuff indicator, then Hide From Any Player on another, changed the first indicator's selection. Both controls wrote the same profile-wide
nonplayerMode.Store the source choice on each indicator and use it for dropdown state, grid/effect filters, display invalidation and corpse eligibility. Existing profiles retain their current choices through a one-time migration covering all spec buckets. The base grid keeps its own choice.
Player and non-player sources claim separate records, so opposite Show filters both render; the first claim still wins within each source. When base and indicator Hide filters exclude opposite sources, omit the unsatisfiable record instead of ignoring an exclusion. Dispel-filter behavior is unchanged.
How was it tested?
mainat271ffc30(v9.1.8); two Lua files changed.Screenshots
Before/after in-game screenshots are unavailable. They still need to be captured during client validation.
Checklist
HookScript/hooksecurefunconly, neverSetScripton Blizzard frames - edits affect addon configuration and synthesized filter records only; no new frame mutations.