Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes Stickybackpack's report that characters with seven or more equipped sockets have a socket strip that expands beyond the character sheet.
Six or fewer sockets keep their existing layout. Larger counts show five sockets per page with previous/next arrows, bounded to the existing six-icon width (188 UI units). Paging preserves each socket's equipment slot and socket index, closes the old gem flyout, and clamps the current page when equipment is removed. The final page keeps the same width so the durability footer stays in place.
The arrows are created only on first overflow. Page changes reuse cached socket records and pooled icons without rescanning inventory. Includes the two generated locale keys; no new settings or socketing APIs.
How was it tested?
Screenshots
Before/after screenshots are missing. The user confirmed the appearance in game, but no screenshots were supplied.
Checklist
HookScript/hooksecurefunconly, neverSetScripton Blizzard frames - new scripts and fields belong only to addon-owned controls; weak-table storage is N/A for this change.