Conversation
Bug: Issue: SkinRoleCheckPopup only stripped the outer chrome/background and never touched the Accept/Decline buttons, which stayed on stock UIPanelButtonTemplate styling, and HookRoleCheckOnShow's OnShow-only hook missed a popup Blizzard had already shown before it attached, most likely for a party member who never opened the Dungeon Finder UI themselves. Fix: Added SkinRoleCheckButton, mirroring SkinQueuePopup's enterButton/leaveButton treatment (stripped textures, owned background, hover highlight, configured border, themed text color) for both buttons, and HookRoleCheckOnShow now skins immediately if the popup is already shown when it attaches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: https://discord.com/channels/585577383847788554/1548926406648664134
Issue: SkinRoleCheckPopup only stripped the outer chrome/background and never touched the Accept/Decline buttons, which stayed on stock UIPanelButtonTemplate styling, and HookRoleCheckOnShow's OnShow-only hook missed a popup Blizzard had already shown before it attached, most likely for a party member who never opened the Dungeon Finder UI themselves.
Fix: Added SkinRoleCheckButton, mirroring SkinQueuePopup's enterButton/leaveButton treatment (stripped textures, owned background, hover highlight, configured border, themed text color) for both buttons, and HookRoleCheckOnShow now skins immediately if the popup is already shown when it attaches.