Conversation
dfrisone
marked this pull request as ready for review
September 17, 2026 17:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Stops the remaining action-bar broadcaster events while cooldowns are secret. The existing full-to-press-and-hold fallback still permits ACTIONBAR_SLOT_CHANGED and PLAYER_ENTERING_WORLD to reach Blizzard's cooldown update path under addon taint, producing repeated secret-value SetCooldown errors. The guard now selects off for both active broadcaster modes.
This ports the runtime behavior of the user-confirmed actionbar-secret-cooldown test ZIP (original commit 0569cb3) onto current main. One file only; no new settings, APIs, timers, or polling.
How was it tested?
Screenshots
N/A: no intended visual change. No new in-game captures supplied.
Checklist
HookScript/hooksecurefunconly, neverSetScripton Blizzard frames - existing broadcaster registration changes operate on Blizzard-owned frames; this patch extends when they are unregistered. No new custom frame fields or script replacement, but full taint/regression acceptance remains unverified.