fix: resolve Omarchy configuration conflicts - #54
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 855da954e2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,3 +1,4 @@ | |||
| GTK_IM_MODULE=fcitx | |||
| INPUT_METHOD=fcitx | |||
There was a problem hiding this comment.
On supported X11 sessions—explicitly detected via /usr/share/xsessions in home/.miserc.toml—GTK applications rely on GTK_IM_MODULE=fcitx to select the installed Fcitx GTK frontend; INPUT_METHOD is not a GTK replacement. Removing this variable from the shared environment file can therefore disable Fcitx input in GTK applications on non-Omarchy X11 hosts. If Omarchy's Wayland session requires it to be unset, scope that behavior to Omarchy rather than removing it globally.
Useful? React with 👍 / 👎.
| ] | ||
|
|
||
| [shell_alias] | ||
| update = "omarchy update" |
There was a problem hiding this comment.
For Omarchy users this only changes the update alias, while README.md:52 still identifies the canonical update command as the literal topgrade. Invoking topgrade directly does not expand this alias, and the interactive Topgrade configuration does not disable system updates, so users following the documented workflow can still bypass Omarchy's snapshot, migration, and package-guard path. Update the command table to direct Omarchy users to update or omarchy update.
Useful? React with 👍 / 👎.
|
@codex review |
1 similar comment
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
updatealias toomarchy updateon Omarchy and document the platform-safeupdatecommandRationale
Omarchy's session/login path expects Bash, while interactive terminals should still use Zsh. Omarchy system updates also need to go through its own updater rather than Topgrade so snapshots, migrations, hooks, and package guards remain in the expected path. Fcitx variables remain dotfiles-owned across platforms, preserving GTK IM support on X11.