fix: recover auto cap from protected working sets - #84
Merged
Conversation
brndnmtthws
marked this pull request as ready for review
July 16, 2026 15:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix auto target sizing so cargo-hold can recover when its selected cap is repeatedly proven unattainable by artifacts that GC deliberately preserves, while retaining the v1.3.5 protection against arbitrary target-directory bloat ratcheting the cap upward.
User Impact
Fallback cache restores no longer remain trapped in a destructive loop that repeatedly removes useful artifacts without ever learning an attainable cap. Confirmed policy-protected working sets can recover to a realistic cap, while unexplained or removable bloat remains unable to drive unbounded growth.
Root Cause
Sizing finals and cap overages were stored in independently bounded histories, allowing an ancient healthy sample to outlive newer over-cap runs. Healthy-only final-to-final growth also provided no useful signal after a metadata-only cold start, and every over-cap result was rejected without recording whether the excess was actually reclaimable under the active preservation policy.
Fix
Validation