Skip to content

fix: Prevent potential panic when extracting x_token from URL #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zkpepe wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Prevent potential panic when extracting x_token from URL #179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions rust/examples/src/bin/grpc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,11 @@ async fn main() -> anyhow::Result<()> {
let x_token = match args.x_token {
Some(t) => t,
None => {
// Split url by forward slash
let mut url_split: Vec<&str> = url.split('/').collect();
let token = url_split.pop().unwrap();
token.to_string()
let mut url_split: Vec<&str> = url.rsplitn(2, '/').collect();
if url_split.len() < 2 {
return Err(anyhow::anyhow!("Invalid URL format, cannot extract x_token"));
}
url_split[0].to_string()
}
};

Expand Down