This repository was archived by the owner on Oct 31, 2025. It is now read-only.
No longer require the workaround for the collatz example#778
Merged
khyperia merged 3 commits intoEmbarkStudios:mainfrom Dec 2, 2021
Merged
No longer require the workaround for the collatz example#778khyperia merged 3 commits intoEmbarkStudios:mainfrom
khyperia merged 3 commits intoEmbarkStudios:mainfrom
Conversation
Contributor
Author
|
Ah, I hadn't updated my version of rust-analyzer. That'd be why format on save wasn't working. |
Contributor
Author
|
Ok, so removing the Int8 capability currently fails in: rust-gpu/crates/rustc_codegen_spirv/src/spirv_type.rs Lines 108 to 109 in 902c51c Which is approximately expected. However, since #667, simply commenting out that error allows valid spir-v to be built which doesn't require that capability. I'm not sure what the approach should be with transiently required capabilities. |
Contributor
|
Now that #809 is in, could you rebase to main and remove the |
khyperia
reviewed
Dec 1, 2021
| build_shader("../../../shaders/simplest-shader", false, &[])?; | ||
| build_shader("../../../shaders/sky-shader", true)?; | ||
| build_shader("../../../shaders/simplest-shader", false)?; | ||
| // We need the int8 capability for using `Option` |
Contributor
There was a problem hiding this comment.
please remove this comment~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from #776, which works exactly as required <3