Fix off-by-one error and add error reporting#1
Open
shadowncs wants to merge 2 commits intoEmilyShepherd:mainfrom
Open
Fix off-by-one error and add error reporting#1shadowncs wants to merge 2 commits intoEmilyShepherd:mainfrom
shadowncs wants to merge 2 commits intoEmilyShepherd:mainfrom
Conversation
thread_queue[section_i].end is non-inclusive so by substracting 1 from ops_in_part, last partition(aka job) op is never processed. Tested by adding prints showing queued operations per thread per slot, and confirming it matches partition total ops.
Summary: When 'apply' fails, the program returns an errorcode. This mapes ota-tool script friendly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes included:
Thank you for this amazing tool! I'm using it to validate Android OTA partial and full packages,