feat: add vit implementation#212
Open
kinggongzilla wants to merge 2 commits into
Open
Conversation
kinggongzilla
requested review from
HennerM,
MauritsBleeker and
Ndles
as code owners
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Contributor
|
kinggongzilla
force-pushed
the
feat-add-vit
branch
from
d515e52 to
bbe6530
Compare
HennerM
approved these changes
May 12, 2026
Ndles
approved these changes
May 12, 2026
| @@ -0,0 +1,44 @@ | |||
| # Copyright © 2025 Emmi AI GmbH. All rights reserved. | |||
|
|
|||
Collaborator
There was a problem hiding this comment.
Should we move this one too src/noether/modeling/models/vit.py directly?
Contributor
Author
There was a problem hiding this comment.
for the other models its still in this place. i think if we do this we should move all of the model schemas together in a separate PR maybe?
Member
There was a problem hiding this comment.
I also think it should be done at once
| """Configuration for ViT model""" | ||
|
|
||
| model_config = ConfigDict(extra="forbid") | ||
|
|
Collaborator
There was a problem hiding this comment.
Why is the transformer block config not used?
kinggongzilla
force-pushed
the
feat-add-vit
branch
from
bbe6530 to
cb0923c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Vision Transformer for 2D grid inputs, built on the existing Transformer backbone.