Conversation
|
Also for the time being the ffmpeg files being built already in the directories is probably the smarter way to go with it until we just make a repo for ffmpeg at some point |
I would rather use CMake's importing features to automatically download the ffmpeg files so we don't have to deal with a 155k diff. |
|
That's going to be the annoying part. Last time I built it. It took like 3-5 mins 💀 |
|
If you want I can go make a repo with the built files and we can try to go from there |
|
Update: I'll be trying to get ffmpeg to build and cache along side the build process instead of having all the files in the lib folder |
|
I think it's good now lol |
the lib we use for discord does not support linux the way its used at the moment. I basically just made a function that makes the game load without the discord lib so it can load lol
|
I'll likely finish the pr on Saturday or Sunday. |
| } | ||
| #endif | ||
|
|
||
| #if FFMPEG_AVAILABLE |
There was a problem hiding this comment.
VideoStream's stubbing should take place in video.cpp, not video.h.
| // Created by Jaydenz on 9/4/2025. | ||
| // | ||
|
|
||
| #include "video.h" No newline at end of file |
There was a problem hiding this comment.
Implementation details for VideoStream should be in the source file, not the header file.
|
|
||
| #include "settings.h" | ||
|
|
||
| namespace Encore::RhythmEngine { |
There was a problem hiding this comment.
Why is this in Encore::RhythmEngine?
3 participants
Adds basic features for video backgrounds. You have to have a file called video.mp4 in the song folder for it to detect at the moment. I'll be adding video_start_time as well later on. Also added Hud Position Setting for the older score display "don't know if we still using it or not but yea"