test: keep the frozen scoring vocabulary authoritative instead of aborting - #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Described in #70 and not actually included — the file was never staged. Committing it separately
rather than leaving the PR body claiming something the diff did not contain.
scoring_vocabularyfroze the 51 gloss classes shared with the shipped model so word-recallfigures stay comparable across model changes. Shipping a 287-class model widened that
intersection to 99 classes, and the guard responded by aborting the whole bench.
Aborting is the wrong response to its own design intent: the frozen file is the authority, so
it now wins, and the run prints a loud notice that the current manifest would give a different
set. Letting the set widen would have quietly changed the denominator every recall figure was
measured against — a better-looking number for a different exam.
Testing
python health_words.py --only-test-signersruns and prints the notice, scoring the frozen 51npm run lint,npm run typecheck,npm test,npm run build— unaffected, all pass