chore: Add codec to encode/decode TIC frames to/from byte array#18
Merged
MathieuSabarthes merged 3 commits intoDec 19, 2025
Merged
Conversation
…kage unit test to cover 100% of the package
mathieusab
suggested changes
Dec 18, 2025
| public enum TICFrameDelimiter { | ||
| /** Begin byte (STX, 0x02) for TIC frames. */ | ||
| BEGIN((byte) 0x02), | ||
| /** Begin byte (STX, 0x02) for TIC frames. */ |
There was a problem hiding this comment.
Suggested change
| /** Begin byte (STX, 0x02) for TIC frames. */ | |
| /** End byte (ETX, 0x03) for TIC frames. */ |
| public enum TICGroupDelimiter { | ||
| /** Begin byte (Line Feed, 0x0A) for TIC groups. */ | ||
| BEGIN((byte) 0x0A), | ||
| /** Begin byte (Carriage Return, 0x0D) for TIC groups. */ |
There was a problem hiding this comment.
Suggested change
| /** Begin byte (Carriage Return, 0x0D) for TIC groups. */ | |
| /** End byte (Carriage Return, 0x0D) for TIC groups. */ |
| } | ||
|
|
||
| public static int getOffsetChecksum(byte[] groupBuffer) { | ||
| checkBuffer(groupBuffer); |
There was a problem hiding this comment.
Tu peux utiliser
Objects.requireNonNull(groupBuffer, "groupBuffer must not be null")
Pour vérifier et envoyer une exception en une ligne
MathieuSabarthes
approved these changes
Dec 19, 2025
MathieuSabarthes
merged commit Dec 19, 2025
5354518
into
feature/architecture-redesign
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.