Skip to content

feat: add EsDropdownCheckbox component#1745

Open
hroth1994 wants to merge 1 commit into
mainfrom
code-review-interview
Open

feat: add EsDropdownCheckbox component#1745
hroth1994 wants to merge 1 commit into
mainfrom
code-review-interview

Conversation

@hroth1994
Copy link
Copy Markdown
Contributor

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

  • Adds new EsDropdownCheckbox component for multi-select dropdown with checkboxes
  • Supports string arrays and {label, value} object arrays, matching EsDropdownSelect API
  • Includes Select All / Clear All actions
  • Adds documentation page with examples for basic, disabled, required, and error states

🥼 Testing

  • Run make dev and navigate to /molecules/dropdown-checkbox
  • Verify dropdown opens/closes on click
  • Verify selecting/deselecting checkboxes updates the model value
  • Verify Select All and Clear All work correctly
  • Verify disabled state prevents interaction
  • Verify error state displays error message
  • Test with both string and object option formats

🧐 Feedback Requested / Focus Areas

  • Looking for any and all feedback!

📝 Checklist

  • I have verified accessibility of any new components by:
    • automated check with the WAVE browser extension
    • navigating by keyboard
    • using with a screen reader (e.g. VoiceOver on Safari)
  • I have updated any applicable documentation.

@hroth1994 hroth1994 requested a review from a team as a code owner May 7, 2026 20:46
@hroth1994 hroth1994 removed the request for review from a team May 7, 2026 20:47
@hroth1994 hroth1994 added the fe-interview Used only for frontend interview label May 7, 2026
@hroth1994 hroth1994 force-pushed the code-review-interview branch from 7c02dd4 to 4d2d27a Compare May 11, 2026 14:01
@hroth1994 hroth1994 force-pushed the code-review-interview branch from 4d2d27a to 44eb2e3 Compare May 12, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fe-interview Used only for frontend interview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant