Grupo 6 - #15 e #16 - #32
Open
BernardoRabello wants to merge 14 commits into
Open
Conversation
Adiciona detalhe sobre gráfico no teste executado
CPeluti
requested changes
Nov 28, 2023
CPeluti
left a comment
CPeluti
left a comment
Collaborator
There was a problem hiding this comment.
Em geral está bom, mas precisa de pequenas alterações.
| Dado que eu executei um teste no simulador, | ||
| Então eu deveria ver as skills do robô no teste executado. | ||
|
|
||
| Cenário: Sucesso e Falha |
Collaborator
There was a problem hiding this comment.
Não é adequado para testes de comportamento ter dois comportamentos diferentes a serem testados em um mesmo cenario
Collaborator
There was a problem hiding this comment.
Recomendo quebrar em dois cenários diferentes
| Então a interface deve detectar os erros nos campos de skills, | ||
| E impedir/interromper a execução do teste. | ||
|
|
||
| Cenário: Navigation |
Collaborator
There was a problem hiding this comment.
Pode, ao invés de utilizar "então" duas vezes seguidas, utilizar "e".
| Dado que o teste foi executado com sucesso | ||
| Então eu deveria ver em um gráfico as informações sobre velocidade que foram coletadas durante a execução do teste | ||
|
|
||
| Cenário: Falha na coleta de dados |
Collaborator
There was a problem hiding this comment.
Acho importante um teste falho ter a visualização já que ela pode ajudar a descobrir porque o teste falhou.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrantes:
Bernardo Ramalho Rabello (211055218)
Debora Venturelli Machado (190086238)
Emanuel de Oliveira Barbosa (211010403)
Pedro Arthur de Moura Neves (211055352)
Issues:
#15 e #16