Use Mail::Address methods instead of Email::Address::XS#1155
Open
TamaraNaboulsi wants to merge 2 commits intopostreleasefix/115from
Open
Use Mail::Address methods instead of Email::Address::XS#1155TamaraNaboulsi wants to merge 2 commits intopostreleasefix/115from
TamaraNaboulsi wants to merge 2 commits intopostreleasefix/115from
Conversation
veidenberg
approved these changes
Apr 9, 2026
Contributor
veidenberg
left a comment
veidenberg
left a comment
There was a problem hiding this comment.
Assuming it's tested (no sandbox URL), it looks good to me 👍
Member
Author
Thanks Andres. I tested it locally and on one of the staging sites. I don't have a sandbox set up, but if there's one ready somehwere I can test it there. |
Member
Author
|
When testing on a sandbox, email was not being sent. Turns out there was a typo in a regex that checks the url and the presence of dashes '-' was triggering a warning. Fixed in last commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A fix to a problem created by #1145 where there was a complication in installing Email::Address::XS. The solution devised aims to use methods from Mail::Address instead, which is a package that comes with Mail::Mailer which is already installed.
Views affected
The sending helpdesk email form.