This repository was archived by the owner on Oct 16, 2026. It is now read-only.
Repository navigation
fix(dashboard): enforce configured run source contract - #1426
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dashboard no longer pretends it can serve arbitrary run folders or
index.jsonlfiles as first-class sources. Passing a noncanonical direct source now fails at startup with actionable guidance to use the project's configured.agentv/results/runs/source,--dir <project-dir>, orresults:config, while one-off bundles are redirected toagentv results report.The fix stays local to Dashboard source resolution: supported project auto-discovery and configured remote-results discovery still work, but the legacy positional source path is now treated as unsupported instead of being normalized into a manifest path. The CLI help text and Dashboard docs now describe that canonical run-source contract, and regression coverage exercises both direct run-directory and direct
index.jsonlinputs with a WTG-style noncanonical fixture plus CLI-level failure assertions.Test Plan
bun test apps/cli/test/commands/results/serve.test.tsbun --filter agentv typecheckbun x biome check apps/cli/src/commands/results/serve.ts apps/cli/test/commands/results/serve.test.ts apps/web/src/content/docs/docs/tools/dashboard.mdxbun --filter @agentv/web buildEvidence
HEAD, direct run dir):Serving 1 result(s) from /tmp/.../wtg-dogfood-noncanonical-run/index.jsonlError: Unsupported Dashboard source: /tmp/.../wtg-dogfood-noncanonical-runHEAD, direct index.jsonl):Serving 1 result(s) from /tmp/.../wtg-dogfood-noncanonical-run/index.jsonlError: Unsupported Dashboard source: /tmp/.../wtg-dogfood-noncanonical-run/index.jsonl