This repository was archived by the owner on Oct 16, 2026. It is now read-only.
Repository navigation
fix(skill-trigger): case-insensitive read tool name and support input.path key - #1434
Merged
Merged
Conversation
….path key Fixes #1433. SkillTriggerGrader now matches tool names case-insensitively so agents using lowercase tool names (e.g. pi-coding-agent / pi-sdk) are detected correctly. Also falls back to input.path when input.file_path is absent, covering pi-sdk's Read tool input schema. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Deploying agentv with
|
| Latest commit: |
3a1d702
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://98ab302b.agentv.pages.dev |
| Branch Preview URL: | https://fix-skill-trigger-case-insen.agentv.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SkillTriggerGradernow matchesSkillandReadtool names case-insensitively (.toLowerCase()), so agents using lowercase tool names (pi-coding-agent / pi-sdk) are detected correctlyinput.pathwheninput.file_pathis absent, covering pi-sdk'sReadtool input schemaChanges
packages/core/src/evaluation/graders/skill-trigger.tstoolName === 'Skill'→toolName.toLowerCase() === 'skill'toolName === 'Read'→toolName.toLowerCase() === 'read'input.file_path ?? ''→input.file_path ?? input.path ?? ''packages/core/test/evaluation/graders/skill-trigger.test.ts"read"tool withinput.path(pi-sdk style) → should trigger"Read"withinput.file_path(Claude Code style) → existing behaviour preservedTest plan
skill-trigger.test.tsstill pass (no regressions)read+input.path→passRead+input.file_path→pass🤖 Generated with Claude Code