Skip to content
This repository was archived by the owner on Oct 16, 2026. It is now read-only.

refactor(dashboard): remove Phoenix read-through UI - #1481

Merged
christso merged 1 commit into
mainfrom
refactor/remove-phoenix-readthrough-ui
Jun 22, 2026
Merged

christso merged 1 commit into
mainfrom
refactor/remove-phoenix-readthrough-ui

Conversation

@christso

Copy link
Copy Markdown
Collaborator

Summary

AgentV Dashboard now treats Phoenix only as an external viewer. Run detail no longer asks the server to read Phoenix sessions, traces, or spans; when a result has safe Phoenix external_trace.ui_url metadata, Dashboard renders a sanitized Open in Phoenix link and leaves AgentV artifacts as the canonical source.

This removes the Phoenix Dashboard BFF path, the server-side GraphQL/REST read-through implementation, the embedded Phoenix session panel, and the Dashboard query/types built around agentv.dashboard.phoenix_session.v1. The remaining run-detail response projects sanitized external_trace metadata from manifest records and strips raw external-trace metadata keys from the generic result metadata payload.

Docs and agent-facing product-boundary guidance now describe Phoenix as link-out correlation only, with no px runtime dependency, no Phoenix GraphQL/REST proxy, no embedded Phoenix session/span UI, and no direct Phoenix database access.

Verification

  • bunx biome check apps/cli/src/commands/results/serve.ts apps/cli/test/commands/results/serve.test.ts apps/dashboard/src/components/RunDetail.tsx apps/dashboard/src/lib/api.ts apps/dashboard/src/lib/types.ts apps/dashboard/src/lib/external-trace-link.ts apps/dashboard/src/lib/external-trace-link.test.ts apps/web/src/content/docs/docs/integrations/phoenix.mdx apps/web/src/content/docs/docs/tools/dashboard.mdx apps/web/src/content/docs/docs/tools/prepare.mdx docs/adr/2026-06-11-phoenix-observability-adapter.md docs/adr/2026-06-21-phoenix-read-only-correlation-boundary.md docs/plans/trace-evaluation-architecture.md packages/phoenix-adapter/docs/support-matrix.md AGENTS.md .agents/product-boundary.md STRATEGY.md ROADMAP.md
  • git diff --check
  • bun test apps/dashboard/src/lib/external-trace-link.test.ts
  • bun test apps/cli/test/commands/results/serve.test.ts
  • bun --filter agentv typecheck
  • bun --filter @agentv/dashboard test
  • bun --filter @agentv/dashboard build
  • bun --filter @agentv/web build
  • Guard searches confirmed no Dashboard /phoenix-session endpoint, no PhoenixLinkedSessionPanel, no Phoenix session schema/read-through implementation, and no Phoenix GraphQL/REST runtime path outside policy text and the separate Phoenix adapter/core metadata surfaces.

Evidence

Private evidence branch: EntityProcess/agentv-private:evidence/av-2il-5-remove-phoenix-readthrough-ui at fe3506c.

The captured Dashboard UAT screenshot shows a run detail page with a sanitized Open in Phoenix link. Browser assertions also confirmed the link stripped the query token and the old wrapper labels Phoenix Session, Trace Tree, and Span Details were absent.

Post-Deploy Monitoring & Validation

Validation window: first CI run and first maintainer Dashboard smoke test after merge.

Healthy signals:

  • PR CI passes for build, typecheck, lint, tests, docs, and schema validation.
  • Dashboard run detail loads AgentV run artifacts without calling any /phoenix-session endpoint.
  • Runs with safe Phoenix external_trace.ui_url metadata show only Open in Phoenix.

Failure signals:

  • Browser/network logs show Dashboard requesting Phoenix BFF routes or Phoenix GraphQL/REST.
  • Run detail exposes raw external-trace secrets in result metadata.
  • Dashboard run detail fails to load runs that include external_trace metadata.

Rollback/mitigation: revert this PR if the run-detail route regresses; otherwise keep Phoenix UI work out of Dashboard runtime and file focused follow-ups against safe link metadata handling.

Owner: AgentV maintainers.


Compound Engineering
GPT-5

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying agentv with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9a10aec
Status: ✅  Deploy successful!
Preview URL: https://088bb5a6.agentv.pages.dev
Branch Preview URL: https://refactor-remove-phoenix-read.agentv.pages.dev

View logs

@christso
christso marked this pull request as ready for review June 22, 2026 10:02

@christso christso left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple review completed: focused on the non-deletion logic in run-detail external_trace projection, Dashboard URL sanitization/link rendering, and guard searches for removed Phoenix read-through runtime paths. No blocking issues found.

@christso
christso merged commit 4fd7518 into main Jun 22, 2026
8 checks passed
@christso
christso deleted the refactor/remove-phoenix-readthrough-ui branch June 22, 2026 10:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant