This repository was archived by the owner on Oct 16, 2026. It is now read-only.
Repository navigation
refactor(dashboard): remove Phoenix read-through UI - #1481
Merged
Merged
Conversation
Deploying agentv with
|
| Latest commit: |
9a10aec
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://088bb5a6.agentv.pages.dev |
| Branch Preview URL: | https://refactor-remove-phoenix-read.agentv.pages.dev |
christso
marked this pull request as ready for review
June 22, 2026 10:02
christso
commented
Jun 22, 2026
christso
left a comment
Collaborator
Author
There was a problem hiding this comment.
Simple review completed: focused on the non-deletion logic in run-detail external_trace projection, Dashboard URL sanitization/link rendering, and guard searches for removed Phoenix read-through runtime paths. No blocking issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AgentV Dashboard now treats Phoenix only as an external viewer. Run detail no longer asks the server to read Phoenix sessions, traces, or spans; when a result has safe Phoenix
external_trace.ui_urlmetadata, Dashboard renders a sanitizedOpen in Phoenixlink and leaves AgentV artifacts as the canonical source.This removes the Phoenix Dashboard BFF path, the server-side GraphQL/REST read-through implementation, the embedded Phoenix session panel, and the Dashboard query/types built around
agentv.dashboard.phoenix_session.v1. The remaining run-detail response projects sanitizedexternal_tracemetadata from manifest records and strips raw external-trace metadata keys from the generic result metadata payload.Docs and agent-facing product-boundary guidance now describe Phoenix as link-out correlation only, with no
pxruntime dependency, no Phoenix GraphQL/REST proxy, no embedded Phoenix session/span UI, and no direct Phoenix database access.Verification
bunx biome check apps/cli/src/commands/results/serve.ts apps/cli/test/commands/results/serve.test.ts apps/dashboard/src/components/RunDetail.tsx apps/dashboard/src/lib/api.ts apps/dashboard/src/lib/types.ts apps/dashboard/src/lib/external-trace-link.ts apps/dashboard/src/lib/external-trace-link.test.ts apps/web/src/content/docs/docs/integrations/phoenix.mdx apps/web/src/content/docs/docs/tools/dashboard.mdx apps/web/src/content/docs/docs/tools/prepare.mdx docs/adr/2026-06-11-phoenix-observability-adapter.md docs/adr/2026-06-21-phoenix-read-only-correlation-boundary.md docs/plans/trace-evaluation-architecture.md packages/phoenix-adapter/docs/support-matrix.md AGENTS.md .agents/product-boundary.md STRATEGY.md ROADMAP.mdgit diff --checkbun test apps/dashboard/src/lib/external-trace-link.test.tsbun test apps/cli/test/commands/results/serve.test.tsbun --filter agentv typecheckbun --filter @agentv/dashboard testbun --filter @agentv/dashboard buildbun --filter @agentv/web build/phoenix-sessionendpoint, noPhoenixLinkedSessionPanel, no Phoenix session schema/read-through implementation, and no Phoenix GraphQL/REST runtime path outside policy text and the separate Phoenix adapter/core metadata surfaces.Evidence
Private evidence branch:
EntityProcess/agentv-private:evidence/av-2il-5-remove-phoenix-readthrough-uiatfe3506c.The captured Dashboard UAT screenshot shows a run detail page with a sanitized
Open in Phoenixlink. Browser assertions also confirmed the link stripped the query token and the old wrapper labelsPhoenix Session,Trace Tree, andSpan Detailswere absent.Post-Deploy Monitoring & Validation
Validation window: first CI run and first maintainer Dashboard smoke test after merge.
Healthy signals:
/phoenix-sessionendpoint.external_trace.ui_urlmetadata show onlyOpen in Phoenix.Failure signals:
external_tracemetadata.Rollback/mitigation: revert this PR if the run-detail route regresses; otherwise keep Phoenix UI work out of Dashboard runtime and file focused follow-ups against safe link metadata handling.
Owner: AgentV maintainers.