Repository navigation
fix(dashboard): show file contents inline in run Files tab - #1501
Merged
Merged
Conversation
The inline run-detail panel renders EvalDetail inside a fixed-height block container, but EvalDetail's root used only `min-h-full` (min-height, leaving `height: auto` / indefinite). Percentage heights on descendants (`h-full` down to the Monaco file viewer with height="100%") therefore collapsed to 0, so the Files tab content pane rendered blank. The Full Page route worked because there EvalDetail is a flex item of a flex column, giving it a definite height. Add `h-full` to the root so its height is definite regardless of parent type, letting the height chain resolve and the Monaco viewer fill the pane inline. `min-h-full` is preserved so the Full Page view behavior is unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Deploying agentv with
|
| Latest commit: |
654c3b0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0f78fa83.agentv.pages.dev |
| Branch Preview URL: | https://fix-files-tab.agentv.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the run/results detail view, selecting the Files tab shows the file list but the file content pane renders blank. The content only appears via Full Page.
Root cause
The inline run-detail panel renders
EvalDetailinside a fixed-height block container (h-[36rem] … overflow-hidden), butEvalDetail's root used onlymin-h-full(min-height;height: auto→ indefinite). Percentage heights cascade only from a definite-height ancestor, so everyh-fulldescendant down to the Monaco viewer (height="100%") collapsed to 0px. Full Page works because thereEvalDetailis a flex item of aflex flex-colparent, giving it a definite height.Fix
apps/dashboard/src/components/EvalDetail.tsxroot:flex min-h-full flex-col→flex h-full min-h-full flex-col.h-fullmakes the height definite regardless of parent type;min-h-fullkept so Full Page is unchanged.Validation
apps/dashboardtsc -b && vite build→ ✓apps/dashboardbun test→ 122 pass, 0 fail