Repository navigation
Add unit tests for 5 untested modules, align CI and Makefile - #42
Merged
Merged
Conversation
- Add unit tests for blocks.lua, academic.lua, reader_inlines.lua, reader_blocks.lua, and reader_academic.lua (235 new assertions, 505 total) - Add golden baseline comparison step to CI pipeline - Align make lint flags with CI (--no-unused-args --no-max-line-length) - Replace hardcoded test file list with wildcard discovery - Add test-all target for single-command full validation - Update CONTRIBUTING.md pre-PR command to use make test-all - Fix README Pandoc version requirement: 2.11+ to 3.0+
gvonnessi
force-pushed
the
chore/cleanup-tests-ci
branch
from
February 17, 2026 01:44
5077e56 to
9d08bef
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
blocks.lua,academic.lua,reader_inlines.lua,reader_blocks.lua, andreader_academic.lua(235 new assertions, 505 total across 11 test files)make test-golden) to CI pipelinemake lintflags with CI (--no-unused-args --no-max-line-length)test-allMakefile target for single-command full validationmake test-allTest plan
make test-unit— all 11 unit test files discovered and pass (505 assertions)make test-golden— 27 golden baselines matchmake test-reader— 27 round-trip tests passmake validate— JSON structure validation passes