Conversation
`lookup(jljit, name)` is deprecated in LLVM.jl 9.8.0+ (adapting to JuliaLang/julia#60988). Update both call sites in orcv2.jl to pass an explicit JITDylib and bump the compat bound to 9.8.1. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/src/compiler/orcv2.jl b/src/compiler/orcv2.jl
index 17dbb340..5cc1a7a8 100644
--- a/src/compiler/orcv2.jl
+++ b/src/compiler/orcv2.jl
@@ -170,7 +170,7 @@ function add_trampoline!(jd, (lljit, lctm, ism), entry, target)
mu = LLVM.reexports(lctm, ism, jd, [alias])
LLVM.define(jd, mu)
- LLVM.lookup(lljit, jd, entry)
+ return LLVM.lookup(lljit, jd, entry)
end
function prepare!(mod)
@@ -293,7 +293,7 @@ end
function lookup(name)
lljit = jit[].jit
- LLVM.lookup(lljit, JITDylib(lljit), name)
+ return LLVM.lookup(lljit, JITDylib(lljit), name)
end
end # module |
Contributor
Benchmark Results
Benchmark PlotsA plot of the benchmark results has been uploaded as an artifact at https://github.com/EnzymeAD/Enzyme.jl/actions/runs/25788306744/artifacts/6965634733. |
wsmoses
reviewed
May 13, 2026
| function lookup(name) | ||
| LLVM.lookup(jit[].jit, name) | ||
| lljit = jit[].jit | ||
| LLVM.lookup(lljit, JITDylib(lljit), name) |
Member
There was a problem hiding this comment.
is the dylib something generated a new each time? this feels wrong if so then
Member
There was a problem hiding this comment.
@vchuravy without this PR doctests are red causing chaos. I'm going to merge for now to unblock CI.
Can you address this in post commit?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lookup(jljit, name)is deprecated in LLVM.jl 9.8.0+ to adapt to [jitlayers] add missing JD parameter to remaining external API call JuliaLang/julia#60988JITDylibto bothlookupcall sites insrc/compiler/orcv2.jl9.8.1Cousin-PR to JuliaGPU/GPUCompiler.jl#796
🤖 Generated with Claude Code