Skip to content

Try gcp bucket cache#2905

Open
wsmoses wants to merge 1 commit into
mainfrom
wsmoses-patch-14
Open

Try gcp bucket cache#2905
wsmoses wants to merge 1 commit into
mainfrom
wsmoses-patch-14

Conversation

@wsmoses
Copy link
Copy Markdown
Member

@wsmoses wsmoses commented May 16, 2026

No description provided.

@wsmoses wsmoses requested a review from giordano May 16, 2026 21:58
with:
version: ${{ inputs.julia_version }}
- uses: julia-actions/cache@v3
- uses: julia-actions/cache@v3.1
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly don't know whether this syntax means 3.1.x only, or 3.1 onwards until v4 (excluded)

- uses: julia-actions/cache@v3.1
id: julia-cache
with:
cache-name: julia-cache;workflow=${{ inputs.julia_version }}-${{ inputs.os }}-${{ inputs.runtime }}-assertions=${{ inputs.assertions }}-${{ github.event_name }}-${{ inputs.test_args }}-${{ inputs.downgrade_testing }}-${{ inputs.localjll || inputs.enzymejax_commit != '' }}-${{ inputs.enzymejax_commit }}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarify cache name, since it's same bucket as Enzyme-JAX

Suggested change
cache-name: julia-cache;workflow=${{ inputs.julia_version }}-${{ inputs.os }}-${{ inputs.runtime }}-assertions=${{ inputs.assertions }}-${{ github.event_name }}-${{ inputs.test_args }}-${{ inputs.downgrade_testing }}-${{ inputs.localjll || inputs.enzymejax_commit != '' }}-${{ inputs.enzymejax_commit }}
cache-name: Reactant-julia-cache;workflow=${{ inputs.julia_version }}-${{ inputs.os }}-${{ inputs.runtime }}-assertions=${{ inputs.assertions }}-${{ github.event_name }}-${{ inputs.test_args }}-${{ inputs.downgrade_testing }}-${{ inputs.localjll || inputs.enzymejax_commit != '' }}-${{ inputs.enzymejax_commit }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants