Skip to content

Fix PJRT runtime assert in IFRT traced_type_inner#2914

Open
csvance wants to merge 1 commit into
EnzymeAD:mainfrom
csvance:fix-pjrt-ifrt-mixup
Open

Fix PJRT runtime assert in IFRT traced_type_inner#2914
csvance wants to merge 1 commit into
EnzymeAD:mainfrom
csvance:fix-pjrt-ifrt-mixup

Conversation

@csvance
Copy link
Copy Markdown

@csvance csvance commented May 20, 2026

This looks like a simple copy and paste error. The specialization is for IFRT but the assert is for PFRT.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 35.96%. Comparing base (b39a1fc) to head (f1e4171).
⚠️ Report is 1077 commits behind head on main.

Files with missing lines Patch % Lines
src/Tracing.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2914       +/-   ##
===========================================
- Coverage   68.16%   35.96%   -32.20%     
===========================================
  Files         109      218      +109     
  Lines       11779    31248    +19469     
===========================================
+ Hits         8029    11238     +3209     
- Misses       3750    20010    +16260     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@wsmoses wsmoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems so, have a test that hits this offhand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants