Store local paths as pathlib paths - #48
Open
EpicWink wants to merge 4 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #48 +/- ##
==========================================
+ Coverage 89.33% 89.43% +0.09%
==========================================
Files 3 3
Lines 741 729 -12
==========================================
- Hits 662 652 -10
+ Misses 79 77 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
Author
|
I need to perform benchmarking to see if this increases or reduces latency and server load |
EpicWink
force-pushed
the
master
branch
2 times, most recently
from
May 12, 2026 08:10
a2c148a to
93ea79d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of always having the file cache return strings, instead return
pathlib.Pathinstances for local paths, and strings for URLs. This turns the string parsing for URL scheme into simply anisinstancecheck.