Skip to content

Store local paths as pathlib paths - #48

Open
EpicWink wants to merge 4 commits into
masterfrom
no-server-parse-path
Open

Store local paths as pathlib paths#48
EpicWink wants to merge 4 commits into
masterfrom
no-server-parse-path

Conversation

@EpicWink

Copy link
Copy Markdown
Owner

Instead of always having the file cache return strings, instead return pathlib.Path instances for local paths, and strings for URLs. This turns the string parsing for URL scheme into simply an isinstance check.

@codecov-commenter

codecov-commenter commented Apr 15, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.43%. Comparing base (69a1d08) to head (cb14eb6).
⚠️ Report is 48 commits behind head on master.

Files with missing lines Patch % Lines
src/proxpi/_cache.py 64.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   89.33%   89.43%   +0.09%     
==========================================
  Files           3        3              
  Lines         741      729      -12     
==========================================
- Hits          662      652      -10     
+ Misses         79       77       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@EpicWink

Copy link
Copy Markdown
Owner Author

I need to perform benchmarking to see if this increases or reduces latency and server load

@EpicWink
EpicWink force-pushed the master branch 2 times, most recently from a2c148a to 93ea79d Compare May 12, 2026 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants