Harden AUR review boundaries and pin adapter identities - #51
Merged
Merged
Conversation
…ss-checks Closes the P2 findings from the adapter review: - commit_version classifies git failures: content-class failures (missing, oversized, non-UTF-8, malformed .SRCINFO) count as per-commit skips; plumbing failures propagate fail-closed, so object corruption can no longer be swallowed as a skip. git show runs first so the happy path is one subprocess per commit; the missing-path skip is granted only via cat-file -t plus git's 'does not exist' stderr, so corruption propagates. - resolve_package stores the matched commit's canonical version, so vercmp aliases resolve to identical store keys and display identities. - prepare_extracted_root refuses an AUR archive whose .SRCINFO pkgbase differs from the resolved package base. - list_versions keeps list_releases' vercmp order instead of re-sorting with semver prerelease rules. - New tests: canonical spelling, vercmp-order regression net, deterministic hash tiebreak, split-package pkgname→pkgbase resolve, oversized .SRCINFO skip, PKGBUILD-as-directory refusal, and pkgbase mismatch refusal.
kridaydave
force-pushed
the
fix-aur-review-findings
branch
from
September 12, 2026 07:04
b824481 to
999ccac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR made by GLM-5.3-Flash from zcode on behalf of Kriday.
Follows up on the adapter code review: the P1s (shallow clone, timeout, url pinning) landed in #50, this closes the P2s. Git plumbing failures inside the .SRCINFO history walk now fail closed instead of being silently counted as skips, and an archive can no longer pretend to be a different package than the one the adapter resolved.
Summary :