Pair renames that only rename params - #12
Merged
Merged
Conversation
The engine only paired renames when code matched letter for letter, so renaming a function and its params showed as a remove plus an add. It now scores similarity 100 for same code, 80 for same code with renamed params, and pairs at a policy threshold that defaults to 100 so nothing changes until you opt in. Commit made by muse-spark-1.3-contributor in opencode on behalf of Kriday.
…ring Review caught untyped names hiding in mixed lists, lifetimes scoring zero, and no upper bound check on the new policy key. Fixed all three and pinned the wiring end to end. Commit made by muse-spark-1.3-contributor in opencode on behalf of Kriday.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR made by muse-spark-1.3-contributor from opencode on behalf of Kriday.
Renaming a function and its params showed as a remove plus an add, which hides what really happened. The engine now scores rename similarity and pairs param-only renames when you opt in.
Summary: