Skip to content

Added verdict exit codes, dogfood CI, and a touched-path fix for visibility - #2

Merged
kridaydave merged 16 commits into
mainfrom
feat/engine-hardening-and-dogfood
Aug 21, 2026
Merged

kridaydave merged 16 commits into
mainfrom
feat/engine-hardening-and-dogfood

Conversation

@kridaydave

Copy link
Copy Markdown
Contributor

PR made by x-preview-f-free from opencode on behalf of Kriday.

This branch grew in parallel with PR #1's engine rewrite. It keeps the reviewed multi-language work but focuses on making oot governable by oot: machine-checkable verdicts, its own policy file, and a CI job that adjudicates every PR. Also fixes a visibility bug that would have cloaked every PR forever.

Summary :

  • Verdict-driven exit codes: 0 = Adjudicated (ship), 1 = Blocked/Cloaked/Embargoed, 2 = usage error
  • Added oot's own visibility.toml and a CI job that adjudicates PRs against main with the release binary
  • Fixed VisibilityPolicy.check to only flag paths a change actually touches (added/removed/content-changed), matching its documented contract — previously any repo containing a .env anywhere was permanently CLOAKED
  • Multi-language engine (Rust/Go/JS) with adversarial-review hardening: bare-name keys + ambiguity disputes instead of receiver-qualified keys

Note on merge strategy vs PR #1: both branches rewrote src/engine/mod.rs. A probe against #1's engine confirmed qualified keys fabricate High conflicts on impl-block moves (pure refactor + unrelated edit => Blocked). Proposal: keep #1's LangConfig architecture + Python support, port this branch's correctness fixes onto it, disable qualifiers or gate them behind ambiguity detection.

Ready For Review !!

- .gitignore: allow fixtures/repo/head/secrets/.env (dummy) so visibility
  test passes; all other *.env still ignored
- fixtures/repo/head/secrets/.env: dummy API_KEY for cloaked verdict test
- README: mark implemented items [x] (git ingestion, visibility, engine,
  docket, in-memory path, git adapter) and keep jj/hosted pending
- clean untracked fixtures/base,head and duplicate tomls

tests: 54/54 pass, clippy/fmt green
… regression, ambiguity disputes, &self engine API
@kridaydave
kridaydave merged commit 28c3ac3 into main Aug 21, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant