fix(deps): refresh lockfile to clear all 9 security advisories - #74
Merged
Merged
Conversation
npm audit went from 9 advisories (7 high, 1 moderate, 1 low) to 0. Six of these had open Dependabot security PRs that were closed during a dependabot config consolidation. Closing a Dependabot PR suppresses that exact fix and deletes its branch, so they could not be reopened and were never recreated -- the packages stayed vulnerable with nothing tracking them: lodash 4.17.23 -> 4.18.1 flatted 3.3.3 -> 3.4.4 @babel/core 7.28.5 -> 7.29.7 @babel/plugin-transform-modules-systemjs 7.28.5 -> 7.29.8 minimatch 3.1.2 -> 3.1.5 serve / serve-handler 14.2.5 -> 14.2.6 / 6.1.6 -> 6.1.7 picomatch 2.3.1 -> 2.3.2 (and nested 4.0.3 -> 4.0.7) ajv 6.12.6 -> 6.15.0 was pre-existing rather than suppressed; npm audit fix skipped it, so it is bumped explicitly. eslint requires ^6.12.4, which 6.15.0 satisfies. All of these are transitive, so package.json is untouched and this is a lockfile-only change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XKNMLCKoVr8Xz1HePmDBXs
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3uzbcqje
pushed a commit
that referenced
this pull request
Sep 13, 2026
Regenerates package-lock.json. Dependabot's grouped update left the lockfile inconsistent -- @rstest/core vendors a newer @rspack/core whose @module-federation/* requirements were never added -- so npm ci failed with six packages missing from the lock. Two @dependabot recreate requests went unanswered. Resolved by keeping main's lockfile (which carries the security refresh from #74) and reconciling it against this branch's package.json. npm ci -> ok, 752 packages npm audit -> 0 vulnerabilities Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FpuRSSAYEkdSSgnaFaoBKK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm auditgoes from 9 advisories (7 high, 1 moderate, 1 low) to 0.Why these were unprotected
Six of these had open Dependabot security PRs — #40, #42, #43, #44, #45, #46 — which I closed during a Dependabot config consolidation, having misread them as routine version bumps. They are all transitive, lockfile-only updates, so none of them showed up in
package.jsonand none looked like security work from the title.Closing a Dependabot PR suppresses that exact fix and Dependabot deletes the branch within seconds, so they could not be reopened. Toggling Dependabot security updates off and on did not regenerate them either. The result was seven open alerts, four of them high severity, with nothing tracking them. This restores each one at the version its original PR proposed.
Changes
ajvwas not one of the suppressed ones.npm audit fixskipped it, so it is bumped explicitly — eslint and@eslint/eslintrcrequire^6.12.4, which 6.15.0 satisfies.Scope
package.jsonis untouched — every one of these is transitive, so this is a lockfile-only change. 28 entries changed, 5 added, 5 removed, out of 792.lockfileVersionstays 3.Caveat
Generated with npm 12.0.2 / node 26.8.1; CI runs npm 10.2.4 / node 20.20.2 (per
.nvmrc, added in #73). Sincepackage.jsonis unchanged and the lockfile version is the same, the risk of churn is low — but CI is the real check here, so please let it run rather than taking the diff on trust.Relationship to #72
Independent. #72 is stuck on a separate Dependabot lockfile bug (
@rstest/corevendors@rspack/core@2.2.2, which needs@module-federation/* ^0.24.1 || ^2.0.0, absent from the lock). This PR deliberately does not depend on that being fixed first, so the security work is not blocked behind it. There will be some overlap in the lockfile when #72 is recreated; whichever merges second will rebase.🤖 Generated with Claude Code
https://claude.ai/code/session_01XKNMLCKoVr8Xz1HePmDBXs