Take fider out of ArgoCD - #74
Draft
jacksonloper wants to merge 1 commit into
Draft
jacksonloper wants to merge 1 commit into
jacksonloper wants to merge 1 commit into
Conversation
Hands fider and fider-db to Flux. Removing the config.json files takes both Applications out of the ApplicationSet; removing the values.yaml files leaves nothing dead behind, since the Flux manifests carry their own copies. DO NOT MERGE until #73 has landed. Without preserveResourcesOnDeletion, this commit deletes the fider database: the Application owns the CNPG Cluster, the Cluster owns the PVC through an ownerReference, and that PV reclaims with Delete. Nothing in secrets/ changes. The `fider` and `fider-db-creds` Secrets come from the standalone bootstrap-secrets app, which is not part of this ApplicationSet and is unaffected. Flux consumes those Secrets rather than managing them. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MeFy2jujRA8ScQqRAshc1f
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hands
fiderandfider-dbto Flux by taking them out of the ApplicationSet. Removing theconfig.jsonfiles removes the Applications; removing thevalues.yamlfiles leaves nothing dead behind, since the Flux manifests in #52 carry their own copies.Why this must wait for #73
Without
preserveResourcesOnDeletion, merging this destroys the fider database:resources-finalizerdeletes the Cluster, the garbage collector reaps the PVC, the PV reclaims. #73 turns that into an orphan instead.Why it must wait for #52
#52 has to be on main before
flux bootstrapcan reconcile it. If this merges first, nothing manages fider at all — it keeps running, but drift and restarts stop being reconciled by anything.Sequencing
preserveResourcesOnDeletion: trueflux bootstrapflux resume kustomization appsStep 4 matters and is easy to skip: ArgoCD renders charts and applies manifests, so no Helm release exists in the cluster. Flux's helm-controller would try a fresh install of
fider-dband collide. The objects need Helm ownership metadata stamped on them first —flux/README.mdhas the commands.Step 6 stays separate so the two controllers never both manage these objects. Between 5 and 6 fider is unmanaged, which is fine and brief.
Not in scope
secrets/is untouched.fider(JWT_SECRET, EMAIL_SMTP_PASSWORD) andfider-db-credscome from the standalonebootstrap-secretsapp, which is not part of this ApplicationSet. Flux consumes those Secrets rather than managing them. Moving them to Flux SOPS needs Azure Key Vault workload identity forkustomize-controllerand is a separate piece of work.Rollback
Revert this PR. ArgoCD regenerates both Applications and re-adopts the resources. Suspend Flux first so they do not fight:
🤖 Generated with Claude Code
https://claude.ai/code/session_01MeFy2jujRA8ScQqRAshc1f