Skip to content

fix(feedback): don't let a missing widget turn Feedback into a no-op #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
masiarek wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(feedback): don't let a missing widget turn Feedback into a no-op #1531

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 22 additions & 7 deletions packages/frontend/src/components/util.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,14 +311,29 @@ export const truncName = (name, maxSize) => {
return name.slice(0, maxSize - 3).concat("...");
};

// Fallback when the feedback widget isn't there to click.
export const FEEDBACK_EMAIL = 'elections@equal.vote';

export const openFeedback = () => {
// simulate clicking the feedback button
const launcherFrame = document.getElementById("launcher-frame");
const button =
(launcherFrame as HTMLIFrameElement).contentWindow.document.getElementsByClassName(
"launcher-button"
)[0];
(button as HTMLButtonElement).click();
// Simulate clicking the widget's own button. Every step here can fail on a
// browser that hasn't loaded the widget — the iframe may be absent, blocked,
// or still loading, and reading its document can throw outright. Unguarded,
// any of those turned the Feedback menu item into a no-op with nothing but a
// console error (#1080, reported on iOS).
try {
const launcherFrame = document.getElementById("launcher-frame") as HTMLIFrameElement | null;
const button = launcherFrame?.contentWindow?.document
?.getElementsByClassName("launcher-button")[0] as HTMLButtonElement | undefined;
if (button) {
button.click();
return;
}
} catch (err) {
console.warn('Feedback widget could not be opened', err);
}

// Rather than appear broken, hand the user a way to reach us.
window.location.href = `mailto:${FEEDBACK_EMAIL}?subject=${encodeURIComponent('BetterVoting feedback')}`;
};

export function scrollToElement(e, opts: { behavior?: ScrollBehavior; delay?: number; cancelOnUserInput?: boolean } = {}) {
Expand Down
Loading